From: intrigeri <intrigeri@boum.org>
Date: Tue, 24 Jun 2008 14:11:22 +0000 (+0000)
Subject: dup: warn about bandwithlimit being unused when desturl is set
X-Git-Tag: backupninja-0.9.6~30
X-Git-Url: https://git.stderr.nl/gitweb?p=matthijs%2Fupstream%2Fbackupninja.git;a=commitdiff_plain;h=c18c24b4e2aebf5328a3b4adc03895f6a5dffe04;hp=f0caa9cc1bc25a9944ceb82d33a116e14bee4632

dup: warn about bandwithlimit being unused when desturl is set
---

diff --git a/examples/example.dup b/examples/example.dup
index 91ff07e..830a47d 100644
--- a/examples/example.dup
+++ b/examples/example.dup
@@ -121,8 +121,8 @@ exclude = /home/*/.gnupg
 #keep = yes
 
 # full destination URL, in duplicity format; if set, desturl overrides
-# sshoptions, destdir, desthost and destuser, and disables testconnect
-# For details, see duplicity manpage, section "URL FORMAT".
+# sshoptions, destdir, desthost and destuser; it also disables testconnect and
+# bandwithlimit. For details, see duplicity manpage, section "URL FORMAT".
 #desturl = file:///usr/local/backup
 #desturl = rsync://user@other.host//var/backup/bla
 
diff --git a/handlers/dup.helper.in b/handlers/dup.helper.in
index 96828ef..c1fbdd5 100644
--- a/handlers/dup.helper.in
+++ b/handlers/dup.helper.in
@@ -398,8 +398,8 @@ incremental = $dup_incremental
 keep = $dup_keep
 
 # full destination URL, in duplicity format; if set, desturl overrides
-# sshoptions, destdir, desthost and destuser, and disables testconnect
-# For details, see duplicity manpage, section "URL FORMAT".
+# sshoptions, destdir, desthost and destuser; it also disables testconnect and
+# bandwithlimit. For details, see duplicity manpage, section "URL FORMAT".
 #desturl = file:///usr/local/backup
 #desturl = rsync://user@other.host//var/backup/bla
 
diff --git a/handlers/dup.in b/handlers/dup.in
index cae9909..0f4e58e 100644
--- a/handlers/dup.in
+++ b/handlers/dup.in
@@ -105,7 +105,10 @@ duplicity_sub="`echo $duplicity_version | @AWK@ -F '.' '{print $3}'`"
 #    --sftp-command ourselves
 
 scpoptions="$sshoptions"
-[ "$bandwidthlimit" == 0 ] || scpoptions="$scpoptions -l $bandwidthlimit"
+if [ "$bandwidthlimit" =! 0 ]; then
+   [ -z "$testurl" ] || warning 'The bandwidthlimit option is not used when desturl is set.'
+   scpoptions="$scpoptions -l $bandwidthlimit"
+fi
 
 # < 0.4.2 : only uses ssh and scp
 if [ "$duplicity_major" -le 0 -a "$duplicity_minor" -le 4 -a "$duplicity_sub" -lt 2 ]; then