Remove (useless) s/*/__star__/ replacement in getconf.

[matthijs/upstream/backupninja.git] / lib / tools.in

diff --git a/lib/tools.in b/lib/tools.in
index 888dad133b627b3bd0d4a12f565609d8c127b40f..2715a00643f4a2477c93378705191f8a28c47619 100644 (file)
--- a/lib/tools.in
+++ b/lib/tools.in
@@ -50,11 +50,9 @@ function printconf() {
 function getconf() {
    ret=`printconf "$1" "$2"`
 
-   # replace * with %, so that it is not globbed.
-   ret="${ret//\\*/__star__}"
-
-   # this is weird, but single quotes are needed to
-   # allow for returned values with spaces. $ret is still expanded
-   # because it is in an 'eval' statement.
-   eval $1='$ret'
+   # We use escape the $ in $ret to delay expansion of $ret, so when $1
+   # is foo, eval sees foo=$ret and properly does the assignment
+   # (without the backslash, the right part of the assignment would be
+   # whatever is in ret and be subject to all kinds of expansion.
+   eval $1=\$ret
 }