rdiff works with sshd banner... rdiff local dest works... create logfile... when...

[matthijs/upstream/backupninja.git] / handlers / rdiff

diff --git a/handlers/rdiff b/handlers/rdiff
index 1f2058f47c4adf6d862a03b9e12140d13868dc33..61eb7f5c7e05d5af6cfa82ae3303909269779f46 100644 (file)
--- a/handlers/rdiff
+++ b/handlers/rdiff
@@ -3,11 +3,14 @@
 # requires rdiff-backup
 #
 
+getconf options
+getconf testconnect yes
+getconf nicelevel 0
+
 setsection source
 getconf type; sourcetype=$type
 getconf label
-getconf user; sourceuser=$user
-getconf keep
+getconf keep 60
 getconf include
 getconf exclude
 
@@ -22,29 +25,31 @@ getconf user; destuser=$user
 getconf host; desthost=$host
 
 [ "$destdir" != "" ] || fatal "Destination directory not set"
-[ "$desttype" == "remote" ] || fatal "Only remote destinations are supported"
 
-# see if we can login
-debug 0 "su $sourceuser -c \"ssh -o PasswordAuthentication=no $desthost -l $destuser 'echo -n 1'\""
-if [ ! $test ]; then
-       result=`su $sourceuser -c "ssh -o PasswordAuthentication=no $desthost -l $destuser 'echo -n 1'" 2>&1`
-       if [ "$result" != "1" ]; then
-               fatal "Can't connect to $desthost as $destuser."
+if [ "$desttype" == "remote" ]; then
+       # see if we can login
+       if [ "$testconnect" == "yes" ]; then
+               hostalive=0
+           debug "ssh -o PasswordAuthentication=no $desthost -l $destuser 'echo -n 1'"
+               ret=`ssh -o PasswordAuthentication=no $desthost -l $destuser 'echo -n host is alive'`
+               if echo $ret | grep "host is alive"; then
+                       debug "Connected to $desthost as $destuser successfully"
+               else
+                       fatal "Can't connect to $desthost as $destuser."
+               fi
        fi
-fi
-
-# see that rdiff-backup has the same version as here
-debug 0 "su $sourceuser -c \"ssh $desthost -l $destuser '$RDIFFBACKUP -V'\""
-if [ ! $test ]; then
-       remoteversion=`su $sourceuser -c "ssh $desthost -l $destuser '$RDIFFBACKUP -V'" 2>&1`
+       # see that rdiff-backup has the same version as here
+       debug "ssh $desthost -l $destuser '$RDIFFBACKUP -V'\""
+       remoteversion=`ssh $desthost -l $destuser "$RDIFFBACKUP -V | grep rdiff-backup"`
        localversion=`$RDIFFBACKUP -V`
        if [ "$remoteversion" != "$localversion" ]; then
                fatal "rdiff-backup does not have the same version on this computer and the backup server."
        fi
+       execstr_serverpart="$destuser@$desthost::$destdir/$label"
+else
+       execstr_serverpart="$destdir/$label"
 fi
 
-execstr_serverpart="$destuser@$desthost::$destdir/$label"
-               
 ### SOURCE ###
 
 [ "$label" != "" ] || fatal "Source missing label"
@@ -55,30 +60,32 @@ execstr_clientpart="/"
        
 ## REMOVE OLD BACKUPS
 
-if [ "$keep" -gt "0" ]; then
-       removestr="rdiff-backup --force --remove-older-than ${keep}D "
-       if [ "$desttype" == "remote" ]; then
-               removestr="${removestr}${destuser}@${desthost}::"
-       fi
-       removestr="${removestr}${destdir}/${label}";
-       
-       debug 0 "su $sourceuser -c '$removestr'"
-       if [ ! $test ]; then
-               output=`su $sourceuser -c "$removestr" 2>&1`
-               code=$?
-               if [ "$code" == "0" ]; then
-                       debug 0 $output
-                       debug 1 "Removing backups older than $keep days succeeded."
-               else
-                       debug 2 $output
-                       debug 2 "Failed removing backups older than $keep."
-               fi
+if [ "`echo $keep | tr -d 0-9`" == "" ]; then
+       keep="${keep}D"
+fi
+
+removestr="rdiff-backup --force --remove-older-than $keep "
+if [ "$desttype" == "remote" ]; then
+       removestr="${removestr}${destuser}@${desthost}::"
+fi
+removestr="${removestr}${destdir}/${label}";
+
+debug "$removestr"
+if [ ! $test ]; then
+       output=`$removestr 2>&1`
+       code=$?
+       if [ "$code" == "0" ]; then
+               debug $output
+               info "Removing backups older than $keep days succeeded."
+       else
+               warning $output
+               warning "Failed removing backups older than $keep."
        fi
 fi
 
 ## EXECUTE ##
-       
-execstr="$RDIFFBACKUP --print-statistics "
+
+execstr="$RDIFFBACKUP $options --print-statistics "
 
 # TODO: order the includes and excludes
 
@@ -100,16 +107,16 @@ execstr="${execstr}--exclude '/*' "
 # include client-part and server-part
 execstr="${execstr}$execstr_clientpart $execstr_serverpart"
 
-debug 0 "su $sourceuser -c '$execstr'"
+debug "$execstr"
 if [ ! $test ]; then
-       output=`su $sourceuser -c "$execstr" 2>&1`
+       output=`nice -n $nicelevel su -c "$execstr" 2>&1`
        code=$?
        if [ "$code" == "0" ]; then
-               debug 0 $output
-               debug 1 "Successfully finished backing up source '$label'"
+               debug $output
+               info "Successfully finished backing up source '$label'"
        else
-               debug 2 $output
-               debug 2 "Failed backup up source '$label'"
+               warning $output
+               warning "Failed backup up source '$label'"
        fi
 fi