action: Create and use a different Logger for each action.

[matthijs/projects/backupninja.git] / src / lib / backupninja / action.py

diff --git a/src/lib/backupninja/action.py b/src/lib/backupninja/action.py
index 83afc954c8d782403d113b9e5dc3daa3eac65fb9..fe1947f4fd2b3c8da7599c1f73e3b161ca0f6d1c 100644 (file)
--- a/src/lib/backupninja/action.py
+++ b/src/lib/backupninja/action.py
@@ -22,6 +22,7 @@
 """ Running backup actions """
 
 import os
+import logging
 import logging as log
 
 from backupninja import config
@@ -52,23 +53,34 @@ def run_action(action_config, opts, global_config):
     configuration file. opts are the parsed commandline options,
     global_config is the parsed global configuration.
     """
+    config_name = os.path.basename(action_config)
     # Split the action filename
-    parts = os.path.basename(action_config).split('.')
+    parts = os.path.basename(config_name).split('.')
     if (len(parts) != 2):
         log.error('Invalid action filename: "%s". Should be in the form name.type, where type is a valid handler.' % action_config)
         return
     (action_name, action_ty) = parts
-    log.info('Running action "%s.%s"', action_name, action_ty)
+
+    action_log = logging.getLogger(config_name)
+    action_log.info('Running')
 
     try:
         # Create a handler for this action
-        action = handlers.create_action(action_ty)
+        action = handlers.create_action(action_ty, logger=action_log)
         # Let the handler load its configuration file
         action.load_config(action_config)
         # Run it
         action.run(test=opts.test)
         action.finish(test=opts.test)
+        # Ask the action if there where any failures
+        success = not action.failed
     except Exception, e:
-        log.error('Running action "%s.%s" failed: %s', action_name, action_ty, e)
+        action_log.error('Unexpected exception: %s', e)
         import traceback
         log.debug(traceback.format_exc())
+        success = False
+
+    if success:
+        action_log.info('Succeeded')
+    else:
+        action_log.info('Failed')