From bf8c3434c59c55704ce931a0954bd1e30c4e02f1 Mon Sep 17 00:00:00 2001
From: Matthijs Kooijman <matthijs@stdin.nl>
Date: Sun, 10 Feb 2008 15:17:03 +0100
Subject: [PATCH]  * Split off the detail and list templates into a normal one
 that generates a full page, by including the _block variant, which generates
 the actual content.  * Make the index template use the character_block and
 influence_block templates, to reduce duplicate template code.

---
 templates/influences/character_detail.html    | 18 +----------
 .../influences/character_detail_block.html    | 15 ++++++++++
 templates/influences/character_list.html      | 16 +---------
 .../influences/character_list_block.html      | 15 ++++++++++
 templates/influences/index.html               | 30 ++++---------------
 templates/influences/influence_detail.html    | 11 +------
 .../influences/influence_detail_block.html    | 11 +++++++
 templates/influences/influence_list.html      |  5 ++++
 .../influences/influence_list_block.html      | 14 +++++++++
 9 files changed, 69 insertions(+), 66 deletions(-)
 create mode 100644 templates/influences/character_detail_block.html
 create mode 100644 templates/influences/character_list_block.html
 create mode 100644 templates/influences/influence_detail_block.html
 create mode 100644 templates/influences/influence_list.html
 create mode 100644 templates/influences/influence_list_block.html

diff --git a/templates/influences/character_detail.html b/templates/influences/character_detail.html
index 09afc68..1f31ec9 100644
--- a/templates/influences/character_detail.html
+++ b/templates/influences/character_detail.html
@@ -1,21 +1,5 @@
 {% extends "base/base.html" %}
-{% load i18n %}
 
 {% block content %}
-
-<h1>{{ object.name }}</h1>
-{% ifequal object.status "N" %}
-<em>{% trans "This character was not yet approved by the SLs" %}</em>
-{% else %}
-<em>{% trans "This character is approved by the SLs" %}</em>
-{% endifequal %}
-<h2>{% blocktrans with object.name as name %}Influences for {{ name }}{% endblocktrans %}</h2>
-<ul>
-{% for influence in object.influence_set.all %}
-	<li><a href="{% url influences_influence_detail influence.pk %}">{{ influence }}</a></li>
-{% endfor %}
-</ul>
-
-<a href="{% url influences_add_influence_for_character object.id %}">{% trans "Submit influence" %}</a>
-
+{% include "influences/character_detail_block.html" %}
 {% endblock %}
diff --git a/templates/influences/character_detail_block.html b/templates/influences/character_detail_block.html
new file mode 100644
index 0000000..6c0a67b
--- /dev/null
+++ b/templates/influences/character_detail_block.html
@@ -0,0 +1,15 @@
+{% load i18n %}
+<h1>{{ object.name }}</h1>
+{% ifequal object.status "N" %}
+<em>{% trans "This character was not yet approved by the SLs" %}</em>
+{% else %}
+<em>{% trans "This character is approved by the SLs" %}</em>
+{% endifequal %}
+<h2>{% blocktrans with object.name as name %}Influences for {{ name }}{% endblocktrans %}</h2>
+<ul>
+{% for influence in object.influence_set.all %}
+	<li><a href="{% url influences_influence_detail influence.pk %}">{{ influence }}</a></li>
+{% endfor %}
+</ul>
+
+<a href="{% url influences_add_influence_for_character object.id %}">{% trans "Submit influence" %}</a>
diff --git a/templates/influences/character_list.html b/templates/influences/character_list.html
index 8b2c3d3..d089d09 100644
--- a/templates/influences/character_list.html
+++ b/templates/influences/character_list.html
@@ -1,19 +1,5 @@
 {% extends "base/base.html" %}
-{% load i18n %}
 
 {% block content %}
-
-<h1>{% trans "Your characters"%}</h1>
-{% if object_list %}
-	<ul>
-	{% for character in object_list %}
-		<li><a href="{% url influences_character_detail character.id %}">{{ character.name }}</a></li>
-	{% endfor %}
-	</ul>
-{% else %}
-	<p>{% trans "No characters. Add a character first, so you can submit your influences." %}</p>
-{% endif %}
-
-<p><a href="{% url influences_add_character %}">{% trans "Add character" %}</a></p>
-
+{% include "influences/character_list_block.html" %}
 {% endblock %}
diff --git a/templates/influences/character_list_block.html b/templates/influences/character_list_block.html
new file mode 100644
index 0000000..27ca771
--- /dev/null
+++ b/templates/influences/character_list_block.html
@@ -0,0 +1,15 @@
+{% load i18n %}
+
+<h1>{% trans "Your characters"%}</h1>
+{% if object_list %}
+	<ul>
+	{% for character in object_list %}
+		<li><a href="{% url influences_character_detail character.id %}">{{ character.name }}</a></li>
+	{% endfor %}
+	</ul>
+{% else %}
+	<p>{% trans "No characters. Add a character first, so you can submit your influences." %}</p>
+{% endif %}
+
+<p><a href="{% url influences_add_character %}">{% trans "Add character" %}</a></p>
+
diff --git a/templates/influences/index.html b/templates/influences/index.html
index ccd2da9..02596e1 100644
--- a/templates/influences/index.html
+++ b/templates/influences/index.html
@@ -1,33 +1,15 @@
 {% extends "base/base.html" %}
-{% load i18n %}
 
 {% block content %}
 
-<h1>{% trans "Your characters"%}</h1>
-{% if characters %}
-	<ul>
-	{% for character in characters %}
-		<li><a href="{% url influences_character_detail character.id %}">{{ character.name }}</a></li>
-	{% endfor %}
-	</ul>
-{% else %}
-	<p>{% trans "No characters. Add a character first, so you can submit your influences." %}</p>
-{% endif %}
-
-<p><a href="{% url influences_add_character %}">{% trans "Add character" %}</a></p>
+{% with characters as object_list %}
+{% include "influences/character_list_block.html" %}
+{% endwith %}
 
 {% if characters %}
-<h1>{% trans "Your influences" %}</h1>
-{% if influences %}
-	<ul>
-	{% for influence in influences %}
-        <li><a href="{% url influences_influence_detail influence.id %}">{{influence.contact }} -- {{ influence.summary }}</a></li>
-	{% endfor %}
-	</ul>
-{% else %}
-	<p>{% trans "No influences yet." %}</p>
+{% with influences as object_list %}
+{% include "influences/influence_list_block.html" %}
+{% endwith %}
 {% endif %}
 
-<p><a href="{% url influences_add_influence %}">{% trans "Submit influence" %}</a></p>
-{% endif %}
 {% endblock %}
diff --git a/templates/influences/influence_detail.html b/templates/influences/influence_detail.html
index 1794579..b06ed88 100644
--- a/templates/influences/influence_detail.html
+++ b/templates/influences/influence_detail.html
@@ -2,14 +2,5 @@
 {% load i18n %}
 
 {% block content %}
-
-<h1>{{ object.summary }}</h1>
-<table>
-<tr><td>{% trans "Contact" %}:</td><td>{{ object.contact }}</td></tr>
-<tr><td>{% trans "Character" %}:</td><td><a href="{% url influences_character_detail object.character.id %}">{{ object.character }}</a></td></tr>
-{% if object.longterm %}
-<tr><td>{% trans "Long term" %}:</td><td>{{ object.longterm|yesno|capfirst }}</td></tr>
-{% endif %}
-</table>
-<p>{{ object.description }}</p>
+{% include "influences/influence_detail_block.html" %}
 {% endblock %}
diff --git a/templates/influences/influence_detail_block.html b/templates/influences/influence_detail_block.html
new file mode 100644
index 0000000..d2c1c3a
--- /dev/null
+++ b/templates/influences/influence_detail_block.html
@@ -0,0 +1,11 @@
+{% load i18n %}
+
+<h1>{{ object.summary }}</h1>
+<table>
+<tr><td>{% trans "Contact" %}:</td><td>{{ object.contact }}</td></tr>
+<tr><td>{% trans "Character" %}:</td><td><a href="{% url influences_character_detail object.character.id %}">{{ object.character }}</a></td></tr>
+{% if object.longterm %}
+<tr><td>{% trans "Long term" %}:</td><td>{{ object.longterm|yesno|capfirst }}</td></tr>
+{% endif %}
+</table>
+<p>{{ object.description }}</p>
diff --git a/templates/influences/influence_list.html b/templates/influences/influence_list.html
new file mode 100644
index 0000000..3f50a1f
--- /dev/null
+++ b/templates/influences/influence_list.html
@@ -0,0 +1,5 @@
+{% extends "base/base.html" %}
+
+{% block content %}
+{% include "influences/influence_list_block.html" %}
+{% endblock %}
diff --git a/templates/influences/influence_list_block.html b/templates/influences/influence_list_block.html
new file mode 100644
index 0000000..e59216f
--- /dev/null
+++ b/templates/influences/influence_list_block.html
@@ -0,0 +1,14 @@
+{% load i18n %}
+
+<h1>{% trans "Your influences" %}</h1>
+{% if object_list %}
+	<ul>
+	{% for influence in object_list %}
+        <li><a href="{% url influences_influence_detail influence.id %}">{{influence.contact }} -- {{ influence.summary }}</a></li>
+	{% endfor %}
+	</ul>
+{% else %}
+	<p>{% trans "No influences yet." %}</p>
+{% endif %}
+
+<p><a href="{% url influences_add_influence %}">{% trans "Submit influence" %}</a></p>
-- 
2.30.2