From 2e919339435fb77e0b7cf20f2f6e0bee4005b1ee Mon Sep 17 00:00:00 2001 From: Matthijs Kooijman Date: Wed, 17 Mar 2010 22:42:44 +0100 Subject: [PATCH] Clarify (and improve) the escaping used in getconf. The code is effectively identical, but a bit clearer. The comment above it should now make it clear what eval is seeing exactly. --- lib/tools.in | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/tools.in b/lib/tools.in index 888dad1..a6dcf26 100644 --- a/lib/tools.in +++ b/lib/tools.in @@ -53,8 +53,9 @@ function getconf() { # replace * with %, so that it is not globbed. ret="${ret//\\*/__star__}" - # this is weird, but single quotes are needed to - # allow for returned values with spaces. $ret is still expanded - # because it is in an 'eval' statement. - eval $1='$ret' + # We use escape the $ in $ret to delay expansion of $ret, so when $1 + # is foo, eval sees foo=$ret and properly does the assignment + # (without the backslash, the right part of the assignment would be + # whatever is in ret and be subject to all kinds of expansion. + eval $1=\$ret } -- 2.30.2