X-Git-Url: https://git.stderr.nl/gitweb?a=blobdiff_plain;f=libchimara%2Finput.c;h=a4511dc57306e6fc2dec661f5496d568b11c8fbf;hb=a42172b750d8736150de2843f11601b694c0d001;hp=df872da5496c6d582142b98b63c692e0e2864dce;hpb=830faf4676d26eb8094688e5ee995c2e2edce0e5;p=rodin%2Fchimara.git

diff --git a/libchimara/input.c b/libchimara/input.c
index df872da..a4511dc 100644
--- a/libchimara/input.c
+++ b/libchimara/input.c
@@ -27,20 +27,6 @@ request_char_event_common(winid_t win, gboolean unicode)
 	g_signal_handler_unblock( win->widget, win->char_input_keypress_handler );
 
 	gdk_threads_enter();
-
-	/* If the request is in a text buffer window, scroll to the end of the
-	 text buffer. TODO: This may scroll text off the top of the window that the
-	 user hasn't read yet. We need to implement a paging mechanism. */
-	if(win->type == wintype_TextBuffer)
-	{
-		GtkTextBuffer *buffer = gtk_text_view_get_buffer( GTK_TEXT_VIEW(win->widget) );
-		GtkTextIter iter;
-		gtk_text_buffer_get_end_iter(buffer, &iter);
-		gtk_text_buffer_place_cursor(buffer, &iter);
-		gtk_text_view_scroll_mark_onscreen(GTK_TEXT_VIEW(win->widget), gtk_text_buffer_get_insert(buffer));
-		/* Why doesn't this always work?? */
-	}
-
 	gtk_widget_grab_focus( GTK_WIDGET(win->widget) );
 	gdk_threads_leave();
 
@@ -141,7 +127,11 @@ text_grid_request_line_event_common(winid_t win, glui32 maxlen, gboolean insert,
 	/* Make the entry as small as possible to fit with the text */
 	gtk_entry_set_has_frame(GTK_ENTRY(win->input_entry), FALSE);
 	GtkBorder border = { 0, 0, 0, 0 };
+
+	/* COMPAT: */
+#if GTK_CHECK_VERSION(2,10,0)
 	gtk_entry_set_inner_border(GTK_ENTRY(win->input_entry), &border);
+#endif
     gtk_entry_set_max_length(GTK_ENTRY(win->input_entry), win->input_length);
     gtk_entry_set_width_chars(GTK_ENTRY(win->input_entry), win->input_length);
 
@@ -195,9 +185,6 @@ text_buffer_request_line_event_common(winid_t win, glui32 maxlen, gboolean inser
 		gtk_text_buffer_get_end_iter(buffer, &end_iter); /* update after text insertion */
 	}
 
-    /* Scroll to input point */
-    gtk_text_view_scroll_mark_onscreen(GTK_TEXT_VIEW(win->widget), input_position);
-
 	/* Apply the correct style to the input prompt */
 	GtkTextIter input_iter;
     gtk_text_buffer_get_iter_at_mark(buffer, &input_iter, input_position);
@@ -430,6 +417,11 @@ on_shutdown_key_press_event(GtkWidget *widget, GdkEventKey *event, winid_t win)
 gboolean
 on_char_input_key_press_event(GtkWidget *widget, GdkEventKey *event, winid_t win)
 {
+	/* Ignore modifier keys, otherwise the char input will already trigger on 
+	the shift key when the user tries to type a capital letter */
+	if(event->is_modifier)
+		return FALSE; /* don't stop the event */
+	
 	glui32 keycode = keyval_to_glk_keycode(event->keyval, win->input_request_type == INPUT_REQUEST_CHARACTER_UNICODE);
 
 	ChimaraGlk *glk = CHIMARA_GLK(gtk_widget_get_ancestor(widget, CHIMARA_TYPE_GLK));
@@ -456,6 +448,8 @@ on_line_input_key_press_event(GtkWidget *widget, GdkEventKey *event, winid_t win
 				|| event->keyval == GDK_Down || event->keyval == GDK_KP_Down)
 			{
 				/* Prevent falling off the end of the history list */
+				if(win->history == NULL)
+					return TRUE;
 				if( (event->keyval == GDK_Up || event->keyval == GDK_KP_Up)
 					&& win->history_pos && win->history_pos->next == NULL)
 					return TRUE;