X-Git-Url: https://git.stderr.nl/gitweb?a=blobdiff_plain;f=handlers%2Fpgsql;h=8629260720b60d0475bcadcb7b6727e8eecb4d66;hb=d600ba40c040c6a75a5b817f80184f60d9dc6eaf;hp=3f7d0b9ac943e38b5f5c82f5318156c44b0420ab;hpb=49dfbcb81f79772c2283a9637eee49616b0b5ac8;p=matthijs%2Fupstream%2Fbackupninja.git

diff --git a/handlers/pgsql b/handlers/pgsql
index 3f7d0b9..8629260 100644
--- a/handlers/pgsql
+++ b/handlers/pgsql
@@ -1,3 +1,4 @@
+# -*- mode: sh; sh-basic-offset: 3; indent-tabs-mode: nil; -*-
 #
 # PostgreSQL handler script for backupninja
 #
@@ -9,28 +10,27 @@ getconf vsname
 
 localhost=`hostname`
 
-# If vservers are configured, decide if the handler should
-# use them or if it should just operate on the host
-if [ "$vservers" == "yes" ]; then
-    if [ ! -z $vsname ]; then		
-	info "using vserver '$vsname'"
-	usevserver=1
-    else
-	info "no vserver name specified, actions will be performed on the host"
-    fi
+# If vservers are enabled, check that $vsname exists, and decide if the
+# handler should use it or if it should just operate on the host.
+local usevserver=no
+if [ $vservers_are_available = yes ]; then
+   if ! vservers_exist "$vsname" ; then
+      fatal "The vserver given in vsname ($vsname) does not exist."
+   else
+      info "using vserver '$vsname'"
+      usevserver=yes
+   fi
 fi
 
 # As needed, make sure that :
-#   * the specified vserver exists and is running
+#   * the specified vserver is running
 #   * the specified vserver or host has the needed executables
-if [ $usevserver ]; then
+if [ $usevserver = yes ]; then
     info "examining vserver '$vsname'"
-    # does it exist ?
     vroot="$VROOTDIR/$vsname"
-    [ -d $vroot ] || fatal "vserver '$vsname' does not exist at '$vroot'"
     # is it running ?
     running=`$VSERVERINFO $vsname RUNNING`
-    if [ $running = 1 ]; then
+    if [ "$running" = "1" ]; then
 	if [ "$databases" == "all" ]; then
 	    [ -x "$vroot`$VSERVER $vsname exec which $PGSQLDUMPALL`" ] || \
 		fatal "Can't find $PGSQLDUMPALL in vserver $vsname."
@@ -57,10 +57,10 @@ fi
 [ -d $vroot$backupdir ] || fatal "Backup directory '$vroot$backupdir'"
 
 # give backup dir the good uid and permissions
-# (in respect to the vserver, if $usevserver)
-pguid=`grep '^postgres:' $vroot/etc/passwd | awk -F: '{print $3}'`
+# (in respect to the vserver, if $usevserver = yes)
+pguid=`getent passwd postgres | awk -F: '{print $3}'`
 [ -n "$pguid" ] || \
-    fatal "No user called postgres`[ $usevserver != 1 ] || echo \" on vserver $vsname\"`."
+    fatal "No user called postgres`[ $usevserver = no ] || echo \" on vserver $vsname\"`."
 debug "chown $pguid $vroot$backupdir"
 chown $pguid $vroot$backupdir
 debug "chmod 700 $vroot$backupdir"
@@ -68,15 +68,15 @@ chmod 700 $vroot$backupdir
 
 # if $databases = all, use pg_dumpall
 if [ "$databases" == "all" ]; then
-    if [ $usevserver ]; then
-	execstr="$VSERVER $vsname exec su - postgres -c $PGSQLDUMPALL > $vroot$backupdir/${vsname}.sql"
+    if [ $usevserver = yes ]; then
+	execstr="$VSERVER $vsname exec su - postgres -c $PGSQLDUMPALL > $backupdir/${vsname}.sql"
     else
 	execstr="su - postgres -c $PGSQLDUMPALL > $backupdir/${localhost}-all.sql"
     fi
     debug "$execstr"
     if [ ! $test ]; then
-	output=`$execstr 2>&1`
-	code=$?
+       output=`$execstr 2>&1`
+       code=$?
 	if [ "$code" == "0" ]; then
 	    debug $output
 	    info "Successfully finished dump of pgsql cluster"
@@ -89,9 +89,9 @@ if [ "$databases" == "all" ]; then
 # else use pg_dump on each specified database
 else
     for db in $databases; do
-	if [ $usevserver ]
+	if [ $usevserver = yes ]
 	    then
-	    execstr="$VSERVER $vsname exec su - postgres -c $PGSQLDUMP $db > $vroot$backupdir/${db}.sql"
+	    execstr="$VSERVER $vsname exec su - postgres -c $PGSQLDUMP $db > $backupdir/${db}.sql"
 	else
 	    execstr="su - postgres -c $PGSQLDUMP $db > $backupdir/${db}.sql"
 	fi