X-Git-Url: https://git.stderr.nl/gitweb?a=blobdiff_plain;f=Normalize.hs;h=93369213e5260f4a3661e1f67769713d00ec4c76;hb=51de92c87cbd5a40c7e58480deef1af00418790f;hp=ee5ea8be621172a8d5b6269570f6e2b303776401;hpb=87f5213db3cfaa65ad805d0ee1c41434e2bed096;p=matthijs%2Fmaster-project%2Fc%CE%BBash.git diff --git a/Normalize.hs b/Normalize.hs index ee5ea8b..9336921 100644 --- a/Normalize.hs +++ b/Normalize.hs @@ -213,6 +213,7 @@ casewild expr@(Case scrut b ty alts) = do -- and binds that to b. mkextracts :: CoreBndr -> Int -> TransformMonad (Maybe (CoreBndr, CoreExpr)) mkextracts b i = + -- TODO: Use free variables instead of is_wild. is_wild is a hack. if is_wild b || Type.isFunTy (Id.idType b) -- Don't create extra bindings for binders that are already wild, or -- for binders that bind function types (to prevent loops with @@ -284,13 +285,12 @@ caseremove expr = return expr caseremovetop = everywhere ("caseremove", caseremove) -------------------------------- --- Application simplification +-- Argument extraction -------------------------------- --- Make sure that all arguments in an application are simple variables. +-- Make sure that all arguments of a representable type are simple variables. appsimpl, appsimpltop :: Transform --- Don't simplify arguments that are already simple. Do simplify datacons, --- however, since we can't portmap literals. -appsimpl expr@(App f (Var v)) | not $ Id.isDataConWorkId v = return expr +-- Don't simplify arguments that are already simple. +appsimpl expr@(App f (Var v)) = return expr -- Simplify all non-applicable (to prevent loops with inlinefun) arguments, -- except for type arguments (since a let can't bind type vars, only a lambda -- can). Do this by introducing a new Let that binds the argument and passing @@ -503,7 +503,7 @@ normalizeBind bndr = then -- This should really only happen at the top level... TODO: Give -- a different error if this happens down in the recursion. - error $ "Function " ++ show bndr ++ " is polymorphic, can't normalize" + error $ "\nNormalize.normalizeBind: Function " ++ show bndr ++ " is polymorphic, can't normalize" else do normalized_funcs <- getA tsNormalized -- See if this function was normalized already @@ -537,4 +537,4 @@ normalizeBind bndr = return () -- We don't have a value for this binder. This really shouldn't -- happen for local id's... - Nothing -> error $ "No value found for binder " ++ pprString bndr ++ "? This should not happen!" + Nothing -> error $ "\nNormalize.normalizeBind: No value found for binder " ++ pprString bndr ++ "? This should not happen!"